Skip to content

⚗️ Remove asserts in async jobs #7434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 26, 2025
Merged

⚗️ Remove asserts in async jobs #7434

merged 4 commits into from
Mar 26, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Mar 26, 2025 •
edited
Loading

What do these changes do?

  • Remove asserts from async jobs framework. Ideally we should have these asserts, but removing them here will allow us to check if they are really the bottleneck we are experiencing in master

Related issue/s

How to test

Dev-ops checklist

@bisgaard-itis bisgaard-itis self-assigned this Mar 26, 2025
@bisgaard-itis bisgaard-itis added the a:storage issue related to storage service label Mar 26, 2025
@bisgaard-itis bisgaard-itis added this to the The Awakening milestone Mar 26, 2025
@codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.67%. Comparing base (d7e6fd3) to head (f8c1af6).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d7e6fd3) and HEAD (f8c1af6). Click for more details.

HEAD has 29 uploads less than BASE
Flag BASE (d7e6fd3) HEAD (f8c1af6)
unittests 30 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7434       +/-   ##
===========================================
- Coverage   87.26%   68.67%   -18.60%     
===========================================
  Files        1714      725      -989     
  Lines       66605    34322    -32283     
  Branches     1131      168      -963     
===========================================
- Hits        58121    23569    -34552     
- Misses       8162    10695     +2533     
+ Partials      322       58      -264
Flag Coverage Δ
integrationtests 65.17% <ø> (-0.03%) ⬇️
unittests 84.38% <100.00%> (-2.06%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.30% <ø> (-8.16%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.54% <ø> (-12.77%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.08% <ø> (-1.04%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage 84.38% <100.00%> (+1.37%) ⬆️
webclient ∅ <ø> (∅)
webserver 59.13% <ø> (-26.54%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e6fd3...f8c1af6. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis
Copy link
Contributor Author

bisgaard-itis commented Mar 26, 2025

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-neutral = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
        • check-skipped = [build] docker images (excluding frontend) (3.11, ubuntu-24.04)
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@bisgaard-itis bisgaard-itis added the 🤖-automerge marks PR as ready to be merged for Mergify label Mar 26, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mrnicegyu11 mrnicegyu11 merged commit 7202315 into ITISFoundation:master Mar 26, 2025
91 of 94 checks passed
@bisgaard-itis bisgaard-itis deleted the remove-asserts-in-async-jobs branch March 26, 2025 13:40
pcrespov
pcrespov approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small note

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 15, 2025
Closed
56 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

Assignees

@bisgaard-itis bisgaard-itis

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:storage issue related to storage service

Projects

None yet

Milestone

The Awakening

Development

Successfully merging this pull request may close these issues.

4 participants

@bisgaard-itis @giancarloromeo @pcrespov @mrnicegyu11